Comments (2)
We'd have to add a dependency on ActiveRecord to do this. Looks like it'd be pretty straightforward, though:
require 'active_record'
module ActiveInteraction
class Base
def self.run(options = {})
new(options).tap do |interaction|
if interaction.valid?
result = nil
::ActiveRecord::Base.transaction do
result = interaction.execute
end
interaction.instance_variable_set(:@result, result)
end
end
end
end
end
Testing it would be a little difficult.
from active_interaction.
I just want to reiterate that testing this is a pain in the ass. The implementation is a piece of cake:
module ActiveInteraction
class Base
begin
require 'active_record'
def self.transaction
::ActiveRecord::Base.transaction do
yield
end
end
rescue LoadError
def self.transaction
yield
end
end
private_class_method :transaction
def self.run(options = {})
new(options).tap do |interaction|
if interaction.valid?
result = transaction { interaction.execute }
interaction.instance_variable_set(:@result, result)
end
end
end
end
end
It's simple enough that I wouldn't feel bad about shipping it without tests, but that feels dirty. I just can't think of a clean way to set up a test that:
- Runs with and without transactions enabled. In other words, with ActiveRecord, then without it.
- Sets up a database connection and a model and saves instances of the model to the database. This is probably the least challenging part, but it's still worth mentioning.
- Checks nested transactions.
On top of all that, ActiveRecord should be disabled for the rest of the test suite because it'll slow it down somewhat.
from active_interaction.
Related Issues (20)
- Handling nested attributes (hash of hashes) HOT 3
- v5 gemspec tied to rails gem and thereby activerecord HOT 1
- Incorrect filtering of array of hashes in v5? HOT 1
- Activeinteraction::Inputs and ActiveRecord #build_where_clause HOT 1
- Bug: Cached default input values HOT 1
- Question: Would you like to add some hactoberfest labels? HOT 1
- Rails 7: ArgumentError (Could not find or build blob: expected attachable) HOT 1
- An `array` filter can mutate the state of the passed in Array instance
- array :emails is always nil. Why? HOT 2
- Missing some documentation on nested hash default options HOT 4
- `ActiveInteraction::Errors#merge!` does not merge custom options HOT 4
- Input access consistency issues HOT 2
- Something strange with full_messages method for errors HOT 2
- When use callback - compose work strange in interaction HOT 1
- Enum filter HOT 2
- Array Filter with default values aren't initialized on each run HOT 2
- Document typecasting to HashWithIndifferentAccess
- Nested forms HOT 4
- Two datatypes with same variable name HOT 2
- Mongoid::Criteria objects are resolved in object filter HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from active_interaction.