Change color of icon about fakespotreviewchecker HOT 5 CLOSED

from fakespotreviewchecker.

Okay, so as far as I can tell there is no real good solution to this. Firefox's internal uses "context-fill" for their icons, but that is currently only available on chrome:// and resource:// urls by default right now, not moz-extension:// which is what extensions use. You can enable it globally by changing the "svg.context-properties.content.enabled" setting in about:config, but that has to be done manually. It's also apparently not possible to detect if the current theme being used is light or dark via the webextension api, so I can't even really use separate icons in an automatic way. So right now I really have three options, none of which I tremendously like.

1. Change the icon to use context-fill and instruct people to enable "svg.context-properties.content.enabled" if they want the icon to match their theme.
2. Change the icon to use a fill color that's halfway between the light and dark theme and hope that it contrasts enough with both for peoples liking. I could only really do this for the default light/dark themes, so it might look terrible on 3rd party themes.
3. Have a setting for the user to toggle between a light and dark icon.

from fakespotreviewchecker.

It is apparently theoretically possible to handle it for custom themes by dynamically generating an icon to contrast the themes colors, but that will be pretty complicated. At least if they use actual color directives to get the url bar color and not images.

from fakespotreviewchecker.

Oh wow, in all honesty I already appreciate your responsiveness with the issue and it honestly speaks volumes about your dedication. I put forth the issue in case it was a relatively simple fix but none of the ones above seem particularly easy to implement from your side. I've flipped through a few themes and it seems like the icon is only almost invisible with the particular shade of black [my] (https://github.com/elibroftw/matte-black-theme) currently active theme uses for the search bar when not actively typing into it. However most other themes seem to just use either grey or white if they choose to go greyscale and the icon is very visible within these colors. All in all, I don't think there's much worth in messing with the icon as it's very visible with the default light and dark themes as well as most custom themes, assuming that they don't die the search bar black like the one I was using.

from fakespotreviewchecker.

I have added context-fill to the svg and also changed the coloring to be a bit easier to see on the default themes. If you want to make the icon use the same color as the other internal icons you can enable "svg.context-properties.content.enabled" in about:config. Beyond that there isn't a whole lot else that can be done right now, so I am going to close the issue pending changes on firefox's end.

from fakespotreviewchecker.