Giter Club home page Giter Club logo

Comments (10)

a-r-m-i-n avatar a-r-m-i-n commented on August 11, 2024 1

Hi! Yes, this is true. The link wizard generates links (t3://file) which are not supported by DCE. Instead, you can simply enter the path of the file as plain text, e.g. fileadmin/templates/my_dce.html.

I'm going to update this issue, to remove the wizard at this point.

from dce.

bytesinmotion avatar bytesinmotion commented on August 11, 2024 1

I'm sorry but WHAT?
You profited from the free work from armin in the first place and now you're not willing to pay for an update script?

The feature didn't get broken by his merge but by TYPO3 v11! And sorry if your customer are not willing to pay for the work of copy&paste for the upgrade to v11 or pay for the update script so they should stay on v10 because upgrading to v11 ain't goin to be free.....

And as armin said, if you don't want to pay him just code the script yourself. It's not a big thing imho...

from dce.

TheOnlyMarkus avatar TheOnlyMarkus commented on August 11, 2024

Sorry, but I need to bump this up again. We are an agency which has developed an uncountable amount of TYPO3 websites with DCE extension over the years. We always used the file picker wizard to select our template files and until TYPO3 10.4 LTS this worked flawlessly. In the database column template_file a reference like t3://file?uid=96 got saved and later interpreted without problems by DCE extension. We are currently on updating many websites to TYPO3 11.5 LTS but unfortunately this change is a big blocker for us having many websites containing 20+ DCEs. For every DCE we have to search the sys_file table and manually craft the file path to the template file. A very tedious and error-prone work.

Two solutions come to my mind:

  1. enable file picker wizard again
  2. provide a migration wizard which automatically replaces old t3:// urls with their corresponding file paths

The sub directory problem described by bytesinmotion seems not to be fully supported by typo3. Please see this bug report and related linked ones: https://forge.typo3.org/issues/95848. It seems TYPO3 running under sub directory is problematic since TYPO3 8.7 LTS, but got fixed in meantime and seems to be broken again since 10.4.21 according to the last comment on https://forge.typo3.org/issues/90689. We never had any TYPO3 installation running on anything other than document root. In my personal opinion this is an uncommon type of configuration, because it always requires some fiddling in htaccess with default rules shipped by TYPO3 itself to get the ENV:CWD mapping working and in some situations there could also be a redirect from / to /subdirectory necessary so that users don't need to type http://example.org/subdirectory to access the website. Redirecting document root to a subdirectory is not so great for SEO especially if the website is getting relaunched under sub directory but was originally running under document root.

from dce.

bytesinmotion avatar bytesinmotion commented on August 11, 2024

The sub directory problem described by bytesinmotion seems not to be fully supported by typo3. Please see this bug report and related linked ones: https://forge.typo3.org/issues/95848. It seems TYPO3 running under sub directory is problematic since TYPO3 8.7 LTS,

It's just for development on my local machine and worked fine pre v11
But yes links in fluid_templates also get wrongly translated

from dce.

TheOnlyMarkus avatar TheOnlyMarkus commented on August 11, 2024

Yes i second that. Tried running a v11 for testing before posting and couldn't get <f:image> to render URLs correctly. I tried experimenting with various combinations of config.absRefPrefix but stopped trying after 20 minutes of failing. I couldn't get both asset link generation and sub page link generation running correctly. One of both was always wrong generated.

from dce.

TheOnlyMarkus avatar TheOnlyMarkus commented on August 11, 2024

@a-r-m-i-n Could you give me an update on this?
Unfortunately, this issue prevents us from providing v11 to our customers.

from dce.

a-r-m-i-n avatar a-r-m-i-n commented on August 11, 2024

@TheOnlyMarkus Using templates via FAL is not supported anymore and won't get supported again.

Instead of t3://file?uid=2 you can simply use the direct file path like fileadmin/templates/dce/whatever.html or even better EXT:your_template_extension/Resources/Templates/....

If the amount of DCEs and templates is too large to do it manually, you could also write an Update script, which does this for you. With the identifier in sys_file you should have all info, you need.

If your agency want to support me, I can write this update script for you. In case you are interessted, please contact me by mail: [email protected] or use the contact form on my website https://v.ieweg.de/#c10

Thanks!

from dce.

TheOnlyMarkus avatar TheOnlyMarkus commented on August 11, 2024

@a-r-m-i-n Sorry, we have already payed you in the past for a feature in 2.8.0, but we won't pay you for the update script since it got broken by your merge 7bfd40f.

Some of our business partners are also locked to v10 because of this issue. No customer would pay us a copy & paste task that is not a visible improvement to them.

Please overthink your decision and decide in the interest of the global community which has a hard time now in replacing all broken template references manually.

from dce.

TheOnlyMarkus avatar TheOnlyMarkus commented on August 11, 2024

Please calm down @bytesinmotion
You understood this wrong. We appreciate the work of Armin very much and used DCE since it got released and even payed further development. But we won't pay for a fix of a thing that got recently broken by a merge. This is our point of view on this.

from dce.

a-r-m-i-n avatar a-r-m-i-n commented on August 11, 2024

@TheOnlyMarkus I checked the code of DCE again, and was able to find the real issue.

Removing the "inputLink" from TCA (7bfd40f) did not cause the issue. It's just UI in backend.

With the recent commit, the t3://file links work again, also without the link wizard.

But keep in mind, that I will remove this functionality entirely, in next major update (I thought, I already did).
I think it is very bad practice to store template files in FAL. It also requires additional database queries, just to determine the path of the template file.

Please overthink your template strategy for the future.


But we won't pay for a fix of a thing that got recently broken by a merge. This is our point of view on this.

You are lucky, that the sun is shining and I'm in a good mood. Did you initially paid for the feature you are complaining about? Or why is this your point of view?

Let me answer this for you: No you didn't!!!

It was me spening hours and hours of my spare time. And just because of that, you are able to complain about the broken feature. But, that's just my point of view...


This fix will apply in next bugfix release.

from dce.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.