Giter Club home page Giter Club logo

Comments (3)

BudgieInWA avatar BudgieInWA commented on June 20, 2024

Sound good to me! I'm in favour of putting lane turn restrictions in LaneSpec, that seems like the right place for it to live.

from osm2streets.

dabreegster avatar dabreegster commented on June 20, 2024

I thought I was done, but the test diffs are looking big. The trouble is

// Check what OSM tags differ. Explicitly allow some keys. Note that lanes tagging doesn't
. Previously a bunch of degenerate intersections were not collapsed, and with the change, they are. In some of the examples, the geometry is a big degradation. arizona_highways before:
Screenshot from 2022-11-23 17-49-35
After:
Screenshot from 2022-11-23 17-49-53
Root cause is https://www.openstreetmap.org/way/23806628 getting merged, now that smoothness differing between the two roads doesn't matter. But looking at this example more closely, the "before" is pretty broken, because the offramp physically overlaps the other road. The "after" looks funky, but it does "correctly" trim things to avoid overlap.

So, I'll look through all the tests carefully. It was an accident things looked differently before.

from osm2streets.

dabreegster avatar dabreegster commented on June 20, 2024

Aside: IIUC, placement would be helpful to tag and make use of for cases like this

from osm2streets.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.