Comments (13)
Mm. So we should manually encode the URLs we send to thes library?
If so: why is this not handled by the library? Looks like a bug to me!
from phumbor.
Perhaps your production Thumbor server is misconfigured. Is it definitely using the same key you're using to generate these URLs?
from phumbor.
What version of Thumbor are you using? Which of the URLs causes the error?
from phumbor.
We are using version 4.12.2 and both URLs are failing. Unsafe URLs work without any issues which is good for development, but we want to make use of the secure URLs when we go live. Any thoughts?
from phumbor.
I'm not quite sure. Can you confirm that you get a different URL when you use thumbor-url
to generate the URL? E.g.:
thumbor-url --key="<key>" --width=252 --height=198 https://s3.amazonaws.com/bucket-name/rP1ysDPH_Photo_Apr_18_8_46_13_PM.jpg
from phumbor.
Same result as the first URL above:
/5DlvHS38TZ3OTS2t7qKdKzN6lU4=/252x198/https://s3.amazonaws.com/bucket-name/rP1ysDPH_Photo_Apr_18_8_46_13_PM.jpg
Could it be the version of Thumbor we are using?
from phumbor.
Could it be because the last part of your url is not urlencoded ?
from phumbor.
How did you guys solve this? Having the same issue right now
from phumbor.
@harto That was our case. Probably might be worth mentioning it better in docs
from phumbor.
At least in newer Thumbor versions, the entire image URL should be urlencoded, since it is used as an URL part itself. This library should handle that.
from phumbor.
I think I've fixed this in webfactory#1, you could try webfactory/phumbor: ^1.2.3
on Composer.
from phumbor.
I can confirm that the fix in webfactory/phumbor: ^1.2.3
solves the issue. @mpdude Can you create a PR for this?
from phumbor.
Since this issue here is three years old and as #21 also tries to fix it (in a slightly different way), my assumption was that this project here has been abandoned.
Thatβs why I forked it (with a heavy heart) and re-published it as webfactory/phumbor.
from phumbor.
Related Issues (7)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from phumbor.