[Feature]Allow to append, not only override css classes about nova-fields HOT 5 CLOSED

I would totally advocate for add* type methods rather than a cryptic Boolean tacked on

from nova-fields.

I could live with that, but in my eyes, its just splitting hairs.

The current method is just manipulating the css classes of the fields. At the moment, you don't know if it appends or if it overwrites. So to make it not "cryptic", you would have to change these method names as well to "changeInputClass, changeLabelClass", etc. (or updateLabelClass, etc.). So you would not only double the methods, but you would also break current behaviour.

from nova-fields.

Sounds good to me. I’ll take a look on this and think in the best api.

from nova-fields.

I only advocated for clarity since, a setter (inputClasses) and an adder (addInputClass) just seem more straight forward to someone reading the code. Rather than having to hit up documentation (which at the moment doesn't really exist, not blaming anyone), the clear and readable separation of changing the class vs adding a class is clear. Additionally there is already at least one example of this kind of thing in laravel already. For example in the query builder there is select (replacing the current selects) and addSelect ( just adding a new select). I don't think we would need to actually change much of the current names and still end up in a clear functionality description.

Another way of looking at it is in terms of what it is, a POPO. Most attributes are get/set via what they are named at a property level so it would also fall in line with not only normal objects but also most other languages that I can think of off-hand. With an additional function being used to not straight-up change the property, but instead a function that could modify the underlying property.

from nova-fields.

Added the following methods to 0.3.0:

• addInputClasses
• addWrapperClasses
• addFieldClasses
• addPanelFieldClasses
• addLabelClasses
• addPanelLabelClasses
• addExcerptClasses

from nova-fields.