Giter Club home page Giter Club logo

Comments (9)

rmeissner avatar rmeissner commented on August 16, 2024 1

Maybe we should take a look at https://github.com/rust-lang/log

from safe-client-gateway.

rmeissner avatar rmeissner commented on August 16, 2024 1

We can add this, but it is not required for this issue. This issue is about replacing the print macro with something more inline with proper logging. Therefore the first step would be to use the debug! Macro instead of print!. Once this is changed we can see that logging framework we use to improve the output and filter the logging based on the environment. I am fine with any of the loggers, as I didn't do any comparison between the different loggers.

from safe-client-gateway.

jpalvarezl avatar jpalvarezl commented on August 16, 2024

It seems that log level is defined in the .env file: #43

from safe-client-gateway.

rmeissner avatar rmeissner commented on August 16, 2024

nick recommends dbg! as a replacement for print!

from safe-client-gateway.

jpalvarezl avatar jpalvarezl commented on August 16, 2024

Hmm this seems to be a wrapper for println!() with the {:?} matcher implied :/ At least that's my understanding of the documentation: https://doc.rust-lang.org/std/macro.dbg.html

We'd still need to find something to log properly.

from safe-client-gateway.

rmeissner avatar rmeissner commented on August 16, 2024

Probably https://docs.rs/log/0.4.11/log/macro.debug.html is more what we want

from safe-client-gateway.

jpalvarezl avatar jpalvarezl commented on August 16, 2024

This one is fairly popular: https://crates.io/crates/pretty_env_logger ? Or you don't want to add a new dependency?

from safe-client-gateway.

jpalvarezl avatar jpalvarezl commented on August 16, 2024

So let's start at the beginning then :)

from safe-client-gateway.

rmeissner avatar rmeissner commented on August 16, 2024

Ohh never mind we need an implementation to use the facade ... I am fine starting with a simple one. Would be nice to add the log level to the env file and write in the readme the different options (or a link to somewhere where the options are mentioned)

from safe-client-gateway.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.