Conflict with MEW Contract manager about etheraddresslookup HOT 5 CLOSED

@Samyoul Good find - yep, I can replicate

I think the POA should be to not do the address logic for EAL if an li has an attribute ng-repeat. What do you think?

from etheraddresslookup.

The current structure with EAL is:

<ul class="dropdown-menu dropdown-menu-left" ng-show="dropdownExistingContracts">
   <!-- ngRepeat: abi in ajaxReq.abiList track by $index -->
	<li ng-repeat="abi in ajaxReq.abiList track by $index" class="ng-scope">
		<a ng-click="selectExistingAbi($index)" class="ng-binding">300 - Warrior for Battle Contract 
			<small class="mono ng-binding">
				<a
				title="See this address on the blockchain explorer"
				href="https://etherscan.io/address/0xaEc98A708810414878c3BCDF46Aad31dEd4a4557"
				class="ext-etheraddresslookup-link ext-etheraddresslookup-link-highlight"
				target="_blank"
				>0xaEc98A708810414878c3BCDF46Aad31dEd4a4557</a>
			</small>
		</a>
	</li>
	...
</ul>

I think the POA should be to not do the address logic for EAL if an li has an attribute ng-repeat. What do you think?

I think that should fix this issue, but will why does injecting the <a> into the HTML cause this issue?

Structure without EAL:

<li ng-repeat="abi in ajaxReq.abiList track by $index" class="ng-scope">
    <a ng-click="selectExistingAbi($index)" class="ng-binding">300 - Warrior for Battle Contract 
        <small class="mono ng-binding">0xaEc98A708810414878c3BCDF46Aad31dEd4a4557</small>
    </a>
</li>

from etheraddresslookup.

I think that the bug is related to the application JS firing before Angular can do its thing, because manually altering the HTML doesn't give this issue.

I think your idea handles this bug as gracefully as possible.

Is it possible to defer the execution of the application JS until after the page JS has finished?

from etheraddresslookup.

Is it possible to defer the execution of the application JS until after the page JS has finished?

Yep, should be able to modify this block in DomManipulator

window.addEventListener("load", function() {
    let objEtherAddressLookup = new EtherAddressLookup();
});

from etheraddresslookup.

Will be looking at this tonight 1900 (GMT timezone)

from etheraddresslookup.