Giter Club home page Giter Club logo

Comments (8)

409H avatar 409H commented on July 2, 2024 1

What about a transitional set of functionalities that reference pre-existing block explorers, and then move onto developing the block analysis server to pass data to the client?

Sounds good for phase 1! 👍

If we can get .eth strings to become links to blockexplorers that support ENS, then phase 1 is good, then we can start discussing converting the ENS domain on the onclick event to the blockexplorer

from etheraddresslookup.

Samyoul avatar Samyoul commented on July 2, 2024 1

Looking at the enhancements some seem to be dependent on having programmatic access to a blockexplorer.

I think that building a new explorer may be overkill, at the moment any way, when we can use APIs https://etherscan.io/apis.

I'd suggest that we develop a whole new extension to this application, a server side portion that is called by the client extension.

Benefits:

  • We don't expose our API key.
  • We can control API calls, and cache and return results as needed.
  • We build the beginnings of a service that gives the user client side info about an account on the page they are looking at. (which I think is the aim of this project)

I propose that we'll need a new repo for managing this functionality as none of it will be related to the functionality in this repo, except for the calls requesting data.

from etheraddresslookup.

Samyoul avatar Samyoul commented on July 2, 2024

@409H Question, is a dedicated ENS lookup needed for this app? The following urls will give valid results.

https://etherscan.io/address/mewtopia.eth
https://etherscan.io/address/0x7cb57b5a97eabe94205c07890be4c1ad31e486a8

https://etherchain.org/account/mewtopia.eth
https://etherchain.org/account/0x7cb57b5a97eabe94205c07890be4c1ad31e486a8

The logic that currently gives the user a block explorer link is:

objNodes[x].innerHTML = strContent.replace(
	new RegExp(strRegex, "gi"),
	'$1<a title="See this address on the blockchain explorer" ' +
	'href="' + this.strBlockchainExplorer + '/$2" ' +
	'class="ext-etheraddresslookup-link" ' +
	'target="'+ (objBlockchainExplorer.hostname === window.location.hostname ? '_self' : '_blank') +'">$2</a>'
);

Looking at this there are no checks that the link points to a valid address, so I'm presuming that is not a prerequisite.

from etheraddresslookup.

409H avatar 409H commented on July 2, 2024

Ah, sorry, I think I've misunderstood you earlier.

When I said a ENS lookup, I meant some sort of screen that does something similar to what Etherscan does, see below;

image

I think you're saying something along the lines of adding a link to a block explorer (like Etherscan) for strings like mewtopia.eth?

from etheraddresslookup.

Samyoul avatar Samyoul commented on July 2, 2024

Ah, ok, I see. I think I misunderstood you.

I think you're saying something along the lines of adding a link to a block explorer (like Etherscan) for strings like mewtopia.eth?

Yes, this is what I'm suggesting, because at the moment the application converts ethereum addresses into links to a selected block explorer.

In order to create this kind of functionality for EAL the application would need access to an Ethereum node, or better a server that has parsed the block data from the Ethereum blockchain.

What about a transitional set of functionalities that reference pre-existing block explorers, and then move onto developing the block analysis server to pass data to the client?

from etheraddresslookup.

Samyoul avatar Samyoul commented on July 2, 2024

Dependent issues (at least from my understanding):

from etheraddresslookup.

409H avatar 409H commented on July 2, 2024

I agree with the above. I'll review the 2 PRs that are open and get them packaged tonight, then I'll hit you up to chat more about this.

I'm at work right now, so will be in about 10 hours.

from etheraddresslookup.

3esmit avatar 3esmit commented on July 2, 2024

Awesome!

from etheraddresslookup.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.