UnicodeSetAttribute sorts my set about falcano HOT 5 CLOSED

I'm not convinced a set is a better way to manage the queue than a list. That being said, probably not a good idea to sort. Updated link:

from falcano.

After a little research, dynamo will return the set in a random order that differs per request. I still agree it shouldn't be sorted, but do not manage an ordered data set with a set in dynamo.

from falcano.

🤔 good points. I see now that sets are not ordered, lists are https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/HowItWorks.NamingRulesDataTypes.html. So sorted here doesn't really affect anything. I wonder what the original intent was of sorted here then and what purpose it serves. Seems like extra computation for no reason.

from falcano.

Actually, no need to wonder. Pynamo https://github.com/pynamodb/PynamoDB/pull/151/files. This seems to exist entirely to facilitate testing (comparing lists that are sorted is easier). We definitely should remove that and optimize for usage performance, not ease of testing, if that is the real reason it exists.

from falcano.

Yeah, it even coerces sets to lists, I fixed it here: #7

from falcano.