Rethink API about sync HOT 12 CLOSED

Coming from Ruby, I like how the old one reads like a sentence (or at least the first part of it). Maybe you could still do that with less verbosity, though.

from sync.

Actually the first argument of the proposed syntax reads better (Sync changes [...]), but the second worse ([...] entityName).

from sync.

So I'm totally bad at this, but what about…

[Sync changes:notes as:@"Notes" ...]

…?

from sync.

Hell, if DATAStack does what I think it does, what about…

[Sync changes:notes as:@"Notes" on:self.dataStack ...]

…? Too crazy!?

from sync.

Hell, if DATAStack does what I think it does, what about…

[Sync changes:notes as:@"Notes" on:self.dataStack ...]

…? Too crazy!?

That's very Swift of you, we should totally change the API once we make a Swift bridge.

from sync.

So ahead of my time, you know. ;-)

from sync.

What about

+ (void)changes:(NSArray *)changes
   inEntityName:(NSString *)entityName
      dataStack:(DATAStack *)dataStack
     completion:(void (^)(NSError *error))completion

from sync.

@RamonGilabert I like that!

from sync.

@3lvis I was thinking in adding just changes inEntity dataStack (or just stack) the user will see the placeholder saying, entityName so I think they'll know what to put.

from sync.

@RamonGilabert I haven't choose that direction because of NSEntityDescription, in a Core Data context when you say entity most of the time you are referring to a NSEntityDescription instance.

We could go for

+ (void)changes:(NSArray *)changes
   inEntityName:(NSString *)entityName
      dataStack:(DATAStack *)dataStack
     completion:(void (^)(NSError *error))completion

And when we rewrite the entire thing in Swift we make it simpler :)

from sync.

All right, let me finish a small surprise and I'll go for it! 👯

from sync.

Fixed on #40!

Thanks @RamonGilabert 🌟 💐 🌟

from sync.