Comments (12)
Coming from Ruby, I like how the old one reads like a sentence (or at least the first part of it). Maybe you could still do that with less verbosity, though.
from sync.
Actually the first argument of the proposed syntax reads better (Sync changes [...]
), but the second worse ([...] entityName
).
from sync.
So I'm totally bad at this, but what about…
[Sync changes:notes as:@"Notes" ...]
…?
from sync.
Hell, if DATAStack does what I think it does, what about…
[Sync changes:notes as:@"Notes" on:self.dataStack ...]
…? Too crazy!?
from sync.
Hell, if DATAStack does what I think it does, what about…
[Sync changes:notes as:@"Notes" on:self.dataStack ...]…? Too crazy!?
That's very Swift of you, we should totally change the API once we make a Swift bridge.
from sync.
So ahead of my time, you know. ;-)
from sync.
What about
+ (void)changes:(NSArray *)changes
inEntityName:(NSString *)entityName
dataStack:(DATAStack *)dataStack
completion:(void (^)(NSError *error))completion
from sync.
@RamonGilabert I like that!
from sync.
@3lvis I was thinking in adding just changes inEntity dataStack
(or just stack) the user will see the placeholder saying, entityName
so I think they'll know what to put.
from sync.
@RamonGilabert I haven't choose that direction because of NSEntityDescription, in a Core Data context when you say entity most of the time you are referring to a NSEntityDescription
instance.
We could go for
+ (void)changes:(NSArray *)changes
inEntityName:(NSString *)entityName
dataStack:(DATAStack *)dataStack
completion:(void (^)(NSError *error))completion
And when we rewrite the entire thing in Swift we make it simpler :)
from sync.
All right, let me finish a small surprise and I'll go for it!
from sync.
Fixed on #40!
Thanks @RamonGilabert
from sync.
Related Issues (20)
- Bumping into 'Invalid type in JSON write (Foundation.__NSSwiftData)' with attribute declared Binary Data HOT 3
- insertOrUpdate doesn't update null values HOT 4
- Missing required module 'Sync.NSEntityDescription_PrimaryKey'
- Swift Package Manager support HOT 5
- Date sync with iOS 13.2 doesn't store in the data model HOT 5
- Doubt about load initial data on Ipad. HOT 1
- can't export many to many relationship HOT 1
- JSON data cannot convert to [[String:Any]] HOT 4
- Module compiled with Swift 5.1.3 cannot be imported by the Swift 5.2 compiler HOT 6
- My project crashes when calling .sync() HOT 1
- FailureJSONResponse HOT 2
- Application crash on NSManagedObject model.export() HOT 4
- disable programmatically Excluding HOT 1
- Module compiled with Swift 5.2.4 cannot be imported by the Swift 5.3 compiler HOT 2
- DataStack initializer crashes our app HOT 7
- Firebase use
- Insert/Update issue HOT 1
- Application crash on NSManagedObject model.export() take 2 HOT 4
- Sync export skips over well defined Transformable Attributes HOT 6
- protocol SyncDelegate: class
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sync.