I tested, the correct string is ([^?=&]+)(=([^&] )), no ([^?=&]+)(=([^&

With current code: <div class="highlight highlight-source-js notranslate position-

Resolved in <a class="issue-link js-issue-link" data-error-text="Failed to load title"

URL parameters: The regular expression question mark is superfluous about 30-seconds-of-code HOT 5 CLOSED

30-seconds commented on May 6, 2024 1

URL parameters: The regular expression question mark is superfluous

from 30-seconds-of-code.

Comments (5)

katongzhong1 commented on May 6, 2024

Never mind! It has changed the way just now

from 30-seconds-of-code.

katongzhong1 commented on May 6, 2024

Sorry, I has tried the new way, the same Problem is founded. The regular expression question mark is superfluous

from 30-seconds-of-code.

skatcat31 commented on May 6, 2024

With current code:

const getUrlParameters = url =>
  url.match(/([^?=&]+)(=([^&]*))?/g).reduce(
    (a, v) => (a[v.slice(0, v.indexOf('='))] = v.slice(v.indexOf('=') + 1), a), {}
  );
getUrlParameters('http://url.com/page?name=Adam&surname=Smith')
var result = {"http://url.com/pag": "http://url.com/page", "name": "Adam", "surname": "Smith"}

Suggested change:

const getUrlParameters = url =>
  url.match(/([^?=&]+)(=([^&]*))/g).reduce(
    (a, v) => (a[v.slice(0, v.indexOf('='))] = v.slice(v.indexOf('=') + 1), a), {}
  );
getUrlParameters('http://url.com/page?name=Adam&surname=Smith')
var result = {name: "Adam", surname: "Smith"}

from 30-seconds-of-code.

Chalarangelo commented on May 6, 2024

Resolved in #96

from 30-seconds-of-code.

lock commented on May 6, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for any follow-up tasks.

from 30-seconds-of-code.

Recommend Projects