Giter Club home page Giter Club logo

Comments (6)

ubershmekel avatar ubershmekel commented on June 3, 2024 1

@ShaynaCummings this looks good to me. If you're available for more test ideas, here are some that would rely on running process_md_texts:

  • No empty links fields.
  • No empty state fields.
  • No empty name fields.
  • More than 200 records found.

That branch looks ready for a PR...

from police-brutality.

 avatar commented on June 3, 2024

This sounds like a great idea - tagging @samgoldman and @ubershmekel for input.

from police-brutality.

ShaynaCummings avatar ShaynaCummings commented on June 3, 2024

Super! This is the kind of thing I was thinking:
master...ShaynaCummings:add-tests

from police-brutality.

samgoldman avatar samgoldman commented on June 3, 2024

I've only contributed a small amount to the script, but I always think testing is a great idea. Let me know if you want me to do anything.

from police-brutality.

ShaynaCummings avatar ShaynaCummings commented on June 3, 2024

@ubershmekel still working on a few more of these cases, but I was wondering if there are future plans for handling invalid or non-parsable entries beyond writing to stdout? I put some specific examples as failing or unfinished tests in the draft PR if you want to take a look.

from police-brutality.

ubershmekel avatar ubershmekel commented on June 3, 2024

@ShaynaCummings if you prefer - you can just commit the tests and I'll hook them up to the github action, or you can cover that in your PR as well.

https://help.github.com/en/actions/language-and-framework-guides/using-python-with-github-actions

To test the action, fork the repo, author your new test action, make a PR to your fork, and check if the tests pass or don't based on what's in the PR. The PR should show a nice big red X or green circle I think if everything got glued. There might even be a way to output exactly which tests failed on which data points.

from police-brutality.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.