Giter Club home page Giter Club logo

Comments (20)

VShawn avatar VShawn commented on June 2, 2024 1

I think it's good :)

from 1remote.

majkinetor avatar majkinetor commented on June 2, 2024 1

Ahh, this is awesome:

image

image

from 1remote.

majkinetor avatar majkinetor commented on June 2, 2024

There is small problem with this and winget - user will have to shutdown app first in order for it to get updated. But that is the same for all portable apps, its not specific to 1RM. There is no way to go around this as winget will first unpack the zip archive over existing location which will fail as exe is already in use. We could technically make -install option make 1RM to copy itself to another location and previously kill any running 1Remote.exe, but I am not sure if we should go those lengths at the moment (although its almost trivial to do).

Chocolatey package will shut down the app first and if it was started before, rerun it after update, so it doesn't have this problem. This can be done as choco uses pwsh script, feature that winget doesn't have.

from 1remote.

majkinetor avatar majkinetor commented on June 2, 2024

As for some examples @VShawn , check up everything. It has CLI option for all installation routines, which I united via single option, but you could separate them too.

from 1remote.

majkinetor avatar majkinetor commented on June 2, 2024

BTW, I would also add here some command line options regarding the running of specific connections. But I consider this to be lower priority task and could be also done in future. Something like:

  • -run #tag-foo
  • -run 'con name foo'

1Remote would accept multiple of those. This would enable 'create desktop shortcut` for specific connection(s).

from 1remote.

VShawn avatar VShawn commented on June 2, 2024

Startup minimized is implemented the wrong way. 1RM should have an app argument that does that

You are right :)

-run 'con name foo'

I designed this feature in the prototype of PRM. users could create shortcuts in the right-click context menu of the connection. then they could search and open connections through tools like Everything. Now, we can still keep the action of creating shortcuts in context menu

P.S.

I'd like that there will be a todo list like #401, for each issue after the discussion is completed, so that we can confirm the work to be done. After all, these tickets may not be started for some time, and without a todo list, we may forget the objectives.

from 1remote.

majkinetor avatar majkinetor commented on June 2, 2024

Yeah, you are right about todo list. However, it can be done only after the discussion, so I'll make sure we have it in the opening post.

from 1remote.

majkinetor avatar majkinetor commented on June 2, 2024

@VShawn, I edited the first post. Please take a look and if you have comments or questions or think something should be modified, bring it on.

from 1remote.

VShawn avatar VShawn commented on June 2, 2024

connection-name or #tag i think it should be case insensitive?

And the command will start all connections named connection-name from all databases?

from this point I wanna add a protocol like path/to/1Remote.exe id:xxxxx to start a specific connection for enable 'create desktop shortcut for specific connection(s).`.

from 1remote.

majkinetor avatar majkinetor commented on June 2, 2024

connection-name or #tag i think it should be case insensitive?

Yes

And the command will start all connections named connection-name from all databases?
from this point I wanna add a protocol like path/to/1Remote.exe id:xxxx

Well, you can have multiple same named connections even in the local database. So yes, all should be started if that is the case I guess.

Yes, we should have connection id, but I would use it in addition to connection name as it is not CLI friendly - majority of the people won't have duplicate connection names anyway. I will add it to the above list.

from 1remote.

majkinetor avatar majkinetor commented on June 2, 2024

BTW, the id:15 is also a valid name. Not sure that we need id: prefix then.

So 1remote 15 17 vs 1remote id:15 id:17.

Perhaps we should forbid naming connections by number ?

from 1remote.

VShawn avatar VShawn commented on June 2, 2024

I've done all the task in this ticke? Do I need to continue adding a desktop shortcut for connection in this ticket?

from 1remote.

majkinetor avatar majkinetor commented on June 2, 2024

Nah, this is for CLI options only.

from 1remote.

majkinetor avatar majkinetor commented on June 2, 2024

Lets keep this open until I test it and add documentation.

from 1remote.

VShawn avatar VShawn commented on June 2, 2024

auto build is donw since I import the COM Windows Script Host Object Model in order to creat a desktop shortcut

var shortcut = new IWshRuntimeLibrary.WshShell().CreateShortcut(shortcutPath);
shortcut.IconLocation =
shortcut.TargetPath = Process.GetCurrentProcess().MainModule!.FileName!;
shortcut.WorkingDirectory = Environment.CurrentDirectory;
shortcut.Arguments = "";
shortcut.Description = Assert.APP_DISPLAY_NAME;
shortcut.Save();

I can build it on my dev env, but if failed with github action.

Build Error from github action: The task "ResolveComReference" is not supported on the .NET Core version of MSBuild.B

So you are not able to test cli until I find out how to fix github action.

from 1remote.

majkinetor avatar majkinetor commented on June 2, 2024

What about this one.

Other then that, you could embed nircmd (license allows it). Its around 100KB.

from 1remote.

VShawn avatar VShawn commented on June 2, 2024

It was eventually built

from 1remote.

majkinetor avatar majkinetor commented on June 2, 2024

I tested it and everything works. Maybe we want to have /? as standardized but its not teribly important as we will have web docs.

from 1remote.

majkinetor avatar majkinetor commented on June 2, 2024

Actually reopening this while docs are not done.

from 1remote.

VShawn avatar VShawn commented on June 2, 2024

You even changed the icon of the shortcut. I also considered mapping the shortcut icon to the server icon when developing, but the icon of connections stored in 1RM is in PNG format while shortcuts only support ICO icons.

from 1remote.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.