Comments (7)
Can I work on this?
from funnies.
@kme211 Go for it!
from funnies.
@1egoman I have been working on adding Gulp in branch feat-2 in my fork. Can you take a look and let me know if I'm on the right track? https://github.com/kme211/funnies/tree/feat-2
I added a default task which doesn't minify as sort of a development build and then a production task which minfies and and sets the NODE_ENV to production so that Uglifyify will remove the development portion of the React lib.
from funnies.
Nice job @kme211! A few notes:
- You should add
envify
to devdependencies (with something likenpm install --save-dev envify
) - It'd be great if gulp could create a
dist
folder if it doesn't exist. (Though it's part of the repo in your fork, I've since removed it from upstream so it's likely not to exist in the future.) - At some point it'd be great to add a command like
gulp watch
to this so it can build in the background as one develops. If that's something you want to tackle, go for it! - I'm pretty sure that this change breaks compatibility with people using node/browserify to
require
in the package. The only way I was able to get this to work previously was to output the source files pre-browserify but post-babel todist/filename.js
(so you'd havedist/funnies.js
,dist/index.js
, etc) and set themain
in thepackage.json
todist/index.js
. - Lastly, I'd prefer the output files to be called
dist/funnies.js
anddist/funnies.min.js
. The links to these should be updated in the readme as well.
Thanks for all your hard work!
from funnies.
@kme211 Also, if you open a pull request with your changes Travis CI will start building you changes, which may be helpful to confirm that everything you've written so far works in CI.
from funnies.
Thanks for taking the time to give me feedback! I think the only thing left is adding a watch task which I'm fine with someone else tackling it since they will probably be able to get to it before I can.
Oh, also I added the babel presets to the dev dependencies but then I realized they were already in the regular dependencies after I submitted my PR.
from funnies.
(Note to self: issue for a watch task #45)
from funnies.
Related Issues (12)
- Consider supporting custom react component? HOT 5
- couple typos
- Disable react components? HOT 8
- Uncaught Error: Cannot find module "funnies/react" HOT 2
- Any desire to update the React component + testing? HOT 2
- Browserified funnies.min.js throws error
- Write an angular directive for funnies! HOT 7
- Gulp watch task HOT 4
- Add more funny phrases! HOT 13
- Allow the react component animation duration to be configurable HOT 1
- Duplicated funnies?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from funnies.