`toSvg` regression for explicit CSS values equal to `inherit` about dom-to-image-more HOT 5 CLOSED

Whoa, nice catch, sorry for not seeing this when first PRed. I'll introduce a regression test and make it pass :) Seems your approach to the fast-path should work.

from dom-to-image-more.

I was of the impression iframe insertion would break with the newish Trusted Type API. (There is a createHTML filter but it only filters DOM strings e.g. innerHTML setter.)

trustedTypes.createPolicy('default', {
    // This code block needs security review, as it's capable of causing DOM XSS.
    createHTML(dirty) { return DOMPurify.sanitize(dirty, {RETURN_TRUSTED_TYPE: true}) }
})

This means we are all green to rely on copyUserComputedStyleFast!

from dom-to-image-more.

Strangely enough, I think the edge case in this issue is described in the comments:

// If the style does not match the default, or it does not match the parent's, set it. We don't know which
// styles are inherited from the parent and which aren't, so we have to always check both.

copyUserComputedStyleFast should be "good enough" to avert the heavy data output problem in #36 and be the only active method going forward.

Need to make a tracking issue to see if there's a really robust method for working with CSS inheritance (both A. stripping extraneous inheritable CSS props, and B. adding back values when CSS explicitly sets inherit or its computed value).

from dom-to-image-more.

I'm addressing this in a new PR... would love to give credit on the package and readmd, but all I have is your github ID

from dom-to-image-more.

Addressed this more completely in #91

from dom-to-image-more.