Bug introduced in 2.9.x: c.getComputedStyle is not a function about dom-to-image-more HOT 15 CLOSED

can't we just get a 2.9.2 to fix this, it's been checked in #42

from dom-to-image-more.

also happens in my react project

from dom-to-image-more.

If anyone's working on 2.8.0 (from that StackOverflow solution), and wants the fix for #29, I have something for you!

Modify the dom-to-image-more file inside your node-modules to include the solution. There's no version between 2.8.0 and 2.9.1, so this'll make do.

Replace the cloneStyle() function with this block of code
` function cloneStyle() {
copyStyle(window.getComputedStyle(original), clone.style);

            function copyStyle(source, target) {
                if (source.cssText) {
                    target.cssText = source.cssText;
                    target.font = source.font; // here, we re-assign the font prop.
                } else copyProperties(source, target);

                function copyProperties(source, target) {
                    util.asArray(source).forEach(function(name) {
                        target.setProperty(
                            name,
                            source.getPropertyValue(name),
                            source.getPropertyPriority(name)
                        );
                    });
                }

                if (root) {
                    ['inset-block', 'inset-block-start', 'inset-block-end'].forEach((prop) => target.removeProperty(prop));
                    ['left', 'right', 'top', 'bottom'].forEach((prop) => {
                        if (target.getPropertyValue(prop)) {
                            target.setProperty(prop, '0px');
                        }
                    });
                }
            }
        }`

This will work until you run npm/update packages (I think). I can fork this if anyone else is running into the same niche bug.

from dom-to-image-more.

@barboite were you able to fix this issue?

from dom-to-image-more.

@talhaamjadx mmhhh, tried to paste this in my node_modules/dom-to-image-more/src/dom-to-image-more.js and re-built my front. It doesn't work, still the same error. Am i supposed to re-install deps with npm ? i'm not familiar with modifying inside node_modules

from dom-to-image-more.

The latest commits also contain a unreleased fix for the Karma test workflow. Any ETA on release @IDisposable?

from dom-to-image-more.

Should be fixed in v2.9.4

from dom-to-image-more.

Unfortunately it's not fixed with v2.9.4 - the problem persits as mentioned in #42 . Downgrading to v2.8.0 solves the problem and is still working properly without TypeError in my project.

from dom-to-image-more.

Can you please point me at a source code reproduction of this issue?

from dom-to-image-more.

Also I hate to be "that techie" but could you confirm the cache been sufficiently cleared to ensure that it was indeed 2.9.4 throwing the error?

from dom-to-image-more.

Also I hate to be "that techie" but could you confirm the cache been sufficiently cleared to ensure that it was indeed 2.9.4 throwing the error?

Thanks for your hint.

Procedure, starting from a flawless Angular v13 project (no error running v2.8.0):
=> npm i dom-to-image-more@latest => clearing browser-cache => restarting dev-server => failure with TypeError
=> npm i [email protected] => restarting dev-server => project is running flawlessly again

Any objections?

from dom-to-image-more.

Could you paste that TypeError log here?

from dom-to-image-more.

Could you paste that TypeError log here?

The TypeError is mentioned in #42.

from dom-to-image-more.

Fixed in v2.9.5, sorry for the inability to test before...

from dom-to-image-more.

Closing since nobody has complained that v2.9.5 didn't fix this more than a year ago :)

from dom-to-image-more.