Black image when capturing an iframe of Google Street View about dom-to-image-more HOT 17 OPEN

Were you able to solve this issue @AnnoyingTechnology ?

Hi, sadly no. I had to use a workaround without using an iframe.

The workaround being : using Google Street View static image API.

from dom-to-image-more.

@IDisposable Here is the fix
https://github.com/ransomsumit/dom-to-image/blob/master/src/dom-to-image.js

from dom-to-image-more.

Try to use toPng, I get a black picture too when I use toJpeg, but work well in toPng

from dom-to-image-more.

Thanks for the tip. But this had already been tried without success.

from dom-to-image-more.

Were you able to solve this issue @AnnoyingTechnology ?

from dom-to-image-more.

Does adding allow="accelerometer; magnetometer; gyroscope" to the iframe work? That would allow the device sensors inside third-party domain loaded scripts.

from dom-to-image-more.

Hey Guys, i just found a big bug with the instanceof checks in the source code.
Trying instanceof with a dom element situated inside an iframe on window prototypes gives false on chrome but gives true on firefox.

Fixing this solved my issue with iframes.

from dom-to-image-more.

@ransomsumit Did you have a PR or a general fix or more details you would like to contribute?

from dom-to-image-more.

Thanks! I've generalized it a bit more to reach up into the contentWindow as needed. Can you confirm that the version in PR #80 works for you so I can make a general release?

from dom-to-image-more.

No it doesn't work properly. it's missing out on styles for several tags. @IDisposable

from dom-to-image-more.

Any suggestion as to what we're missing? I would love to roll out a fix.

from dom-to-image-more.

The one thing I noticed is that some tags For ex. < g > gives out false on instanceof check within the frame for some reason but gives true on root window. So the fail safe will be to check instanceof on root window and the frame window at the same time with proper condition. My fix is working fine with this.

Currently,
I am tackling some weird image event error with makeimage function, if you have any context please tell. @IDisposable

from dom-to-image-more.

I've pushed up some more extensive cleanup, mostly around the finding of the owner window object and also fixed a really silly issue with class name generation used when copying over any ::before or ::after attributes.

Please pull the branch again and see if I've got it working. If you can give me a repro that show the error, I can fix it faster (follow the pattern in the unit testes... an HTML, a CSS, (optionally) a control-image.

from dom-to-image-more.

Maybe it's because iframe has loading=lazy attribute

from dom-to-image-more.

Parallel to the iframe feature request:

from dom-to-image-more.

For iframe cloning:

• We should first check if there is an srcdoc because that is usually inlined as a higher priority than the <iframe> src.
• Same origin = iframe.contentDocument is available: we can attempt a jump from iframe to iframe.contentDocument when getting the children. Similar to #101.
• Otherwise there should be the option to fetch the HTML of src via XHR and inline it.

from dom-to-image-more.

Resources inside the cloned iframe document don't load after the XHR. So cross-origin support is a no-no.
I believe Google Street View is always a cross-origin embed/iframe so it's impossible to take a screenshot of without retooling some kind of advanced browser API and requiring user input after the toSvg call.

from dom-to-image-more.