Feature: Integrate gulp-notify about theme-scaffold HOT 5 CLOSED

I'm not against this, sometimes I do find notifications annoying though, so it should be something that's easily disabled locally. I don't want to add to the noise if someone doesn't want it.

from theme-scaffold.

so it should be something that's easily disabled locally.

There is an environmental variable for just this case: export DISABLE_NOTIFIER=true;

Do you think that is sufficient?

from theme-scaffold.

Also, dropping a note here. While working on Pull Request to replace Live Reload with BrowserSync. I found that BrowserSync has a .notify() method, which we might be able to use for notifications in the browser, as opposed to system notifications.

It might couple BrowserSync a bit too much though as a dependency in to the overall scaffolding eco-system. I mostly just wanted to write this as a reminder for me to research a bit more as an option: https://browsersync.io/docs/api#api-notify

from theme-scaffold.

I attempted to start on a pull request today, which required me to dig in on the existing theme-scaffold architecture. I do not see any areas where gulp-notify might benefit this project at the moment.

I believe my initial thought to include gulp-notify stemmed from a 10up project that likely had retrofitted some aspects of theme-scaffold. Therefore, the scenario for elevating errors/warning out of the console was more obvious. I think it was mostly ESLint messages in that scenario.

I'll leave this open a bit longer in case there is feedback, but right now I'm not seeing this being beneficial.

from theme-scaffold.

@colorful-tones let's close this out if we're not moving forward with it.

from theme-scaffold.