Describe the bug Feedback from <a class="user-mention notranslat

Editor selection unexpectedly defaults to previous choice about convert-to-blocks HOT 3 CLOSED

10up commented on July 22, 2024

Editor selection unexpectedly defaults to previous choice

from convert-to-blocks.

Comments (3)

dinhtungdu commented on July 22, 2024 1

convert-to-blocks/includes/ConvertToBlocks/RevisionSupport.php

Lines 56 to 68 in 5db47f3

 /** 

  * Updates post link if originating from a classic editor page 

  * 

  * @param string $url The post url 

  * @return string 

  */ 

 public function update_edit_post_link( $url ) { 

 if ( $this->container->is_classic_post_referer() ) { 

 return add_query_arg( [ 'classic' => 1 ], $url ); 

 } 

 return $url; 

 }

@tlovett1 It feels wrong to me as well. It makes sense if we view post after edit post with Classic Editor and the edit post link in the frontend directs us to the Classic Editor. But in the admin area, we don't need that behavior because we have two edit links.

from convert-to-blocks.

tlovett1 commented on July 22, 2024

So this is actually coded that way on purpose. To me it feels wrong. Looking for input from others.

from convert-to-blocks.

jeffpaul commented on July 22, 2024

Agreed if there are two edit links that we shouldn't be hijacking that to force whatever was used previously.

from convert-to-blocks.

Editor selection unexpectedly defaults to previous choice about convert-to-blocks HOT 3 CLOSED

Comments (3)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	/**
	* Updates post link if originating from a classic editor page
	*
	* @param string $url The post url
	* @return string
	*/
	public function update_edit_post_link( $url ) {
	if ( $this->container->is_classic_post_referer() ) {
	return add_query_arg( [ 'classic' => 1 ], $url );
	}

	return $url;
	}