Giter Club home page Giter Club logo

Comments (5)

0x09 avatar 0x09 commented on August 26, 2024

Hi @ttsiodras

Thanks, it looks like this was broken by 8df0c23 which added libhfsuser (and others under lib/) to the include path in order to fix inconsistencies building with the bundled vs system utf8proc/ublio. But this also means that the couple of internal headers in those dirs are also added to the path, and since gcc/clang search locations added with -I before system ones, the effect is that when sys/stat.h includes <features.h> libhfsuser's features.h is being included instead.

Renaming the header isn't enough of a solution here because the project shouldn't really be organized in a way that requires the build system to do this. I think the correct thing here would be to just restructure libhfs and libhfsuser so that only their public headers (ones that would be installed with make install-lib) are added to the search path and deal with ublio/utf8proc separately. I'll push up a fix a bit later.

from hfsfuse.

ttsiodras avatar ttsiodras commented on August 26, 2024

I'll push up a fix a bit later.

Excellent. Ping me and I will test it.

from hfsfuse.

0x09 avatar 0x09 commented on August 26, 2024

@ttsiodras I decided to go with a much simpler solution of using -iquote for these includes since this fits better with how the libs are being used internally. Confirmed 32a77ed resolves this specific issue on other systems with glibc, but should stop the issue of polluting the include path in general.

from hfsfuse.

ttsiodras avatar ttsiodras commented on August 26, 2024

I just tested it - works great.

Thank you!

from hfsfuse.

0x09 avatar 0x09 commented on August 26, 2024

@ttsiodras great, thanks for reporting this.

from hfsfuse.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.