Make loading samples progress bar more informative about fiftyone HOT 5 CLOSED

There are two parts, "ingesting" and "inserting". The ingesting is basically obsolete with the updated optimizations and can be removed. The inserting still takes some time but there's no notion of a progress bar we could acquire. That being said, we should remove the progress bar all together

from fiftyone.

For the types of datasets that we currently work with, parsing the samples (ie., creating fo.Sample instances) is pretty quick (thanks to Tyler's recent work). BUT, if the user provides a complicated SampleParser, it may not be so quick to parse the samples. So, a ProgressBar may still be warranted.

The saving part is currently done in a single batch, regardless of dataset size, so we don't have a hook into the process to display a progress bar. However, it may be a better practice to save the samples in batches, both to avoid DB transactions that take a second or longer, and to enable a progress bar to track the progress on the saving.

In fact, it would be preferable to interleave parsing and saving (calls to add_samples()) to prevent the need for storing ALL of the fo.Samples in memory. We're designing the system in such a way that the user can work with any number of samples. So, this would be a required change anyway.

from fiftyone.

Until we have a chance to address the underlying implementation, I removed the progress bar as requested. It's the best option for the current implementation.

from fiftyone.

Updated the issue title to reflect the underlying spirit of this issue now that the existing progress bar has been removed

from fiftyone.

This is completely resolved by #239. There is now a single progress bar that tracks parsing + saving to the DB together as a single operation

from fiftyone.