Comments (8)
It's a hard no for me, unfortunately.
But this is where I draw the line. If there's a need for more complex integration with ffmpeg it should be done via a plugin and not here in the core package.
from motion-canvas.
The FFmpeg exporter is now available as a standalone plugin:
https://github.com/motion-canvas/exporters#installation
from motion-canvas.
Motion Canvas is not meant to be an end-to-end video editing software.
It's supposed to be used in conjunction with Premiere, Da Vinci, Audition, Audacity, etc.
I'm open to a plugin interface that would allow you to create an ffmpeg exporter.
But I definitely don't want to include ffmpeg as a core dependency.
from motion-canvas.
The proposal is simply to make it such that, if the user has ffmpeg installed, they get this QoL boost (is there any common use for wanting the individual frames?). It could be as simple as a try { child_process.exec('ffmpeg ...') } catch {}
, which wouldn't require any additional dependencies.
from motion-canvas.
The proposal is simply to make it such that, if the user has ffmpeg installed, they get this QoL boost
Oki but then the post you linked in your proposed solution is a bit misleading because it uses @ffmpeg-installer/ffmpeg
.
Anyway, I'm willing to allow it. Two things though:
- It should be opt-in. I have ffmpeg installed and I don't want it to run each time I render something.
I propose a new flag for themotion-canvas
command, for instance--ffmpeg
- The options passed to ffmpeg should be configurable. Maybe also through the flag.
But this is where I draw the line. If there's a need for more complex integration with ffmpeg it should be done via a plugin and not here in the core package.
is there any common use for wanting the individual frames?
I'm not sure if I understand the question correctly, but If you're asking for the reason people may use image sequences then:
- Lossless quality.
- Transparency support.
- Ability to re-render only a portion of the animation.
- No point in encoding a video just to re-encode it again in another software.
from motion-canvas.
@aarthificial How about adding configurable lifecycle hooks to motion-canvas? Instead of building ffmpeg as a specialized flag, have a "post-render" string that is run as a command after motion-canvas is done. I imagine there are probably a lot of things people might want to do with the frames once they finish. Like maybe one person's workflow is actually to make a gif using image-magick. The specific ffmpeg command for rendering could then go into the docs so that people can add it if they want. Granted, that requires that they read the docs, but it decouples your tool from the hundreds of ways people might want to use the frames and still allows people to have their convenient workflows.
from motion-canvas.
@Ross-Esmond That's pretty much what I mean by "a plugin interface that would allow you to create an ffmpeg exporter".
But I think implementing something like this will take some time.
I'd like to switch to using sockets instead of HTTP requests first.
And also explore the possibility of using webpack's hooks architecture in order to not reinvent the wheel.
A simple flag seems like a good temporarily solution
from motion-canvas.
ffmpeg
is pretty intrusive dependency for projects due to cross-platform installation requirements, and it not being quickly installable via the CLI (excluding the usage of package managers).
On the other hand, would you be willing to allow the WASM ffmpeg port for exporting directly from the browser? Understood if not, but it'd be nice to just get a "save" button after a render and to be able to get that into your downloads.
If I get the go-ahead, I'd be happy to implement.
from motion-canvas.
Related Issues (20)
- Documentation pages sometimes failed to load on mobile device
- DestinationUV uniform doesn't scale with scene on render HOT 5
- Preview-only Background Color HOT 1
- TXT does not move with parent Line when tweening HOT 5
- Example scene for Code node HOT 1
- Incorrect Code node width when final line is longest
- Switch code node to use treesitter HOT 3
- Add a length() accessor to the Line component HOT 1
- Offline Icon Support HOT 1
- Different Browsers, Same Code, Different Appearance. HOT 1
- Mathematical operations for Vector2 signals HOT 1
- More Playhead Functionality
- `Path` appears like polylines while animating to new values HOT 1
- Documentation (and examples) for: to, do, back
- Document range handles and other parts of the interface HOT 10
- Dynamic point definition for `Spline` yields `Insufficient number of knots` warning. HOT 1
- view.fill(); causes FR drop in Safari on MacOS
- Arrows in the middle of the line
- How to place an animation in an existing web project HOT 3
- add tweening for layout properties HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from motion-canvas.